-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prover): Add FFLONK support to compressor #2766
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itegulov
force-pushed
the
daniyar/fflonk
branch
from
October 10, 2024 05:39
872e85c
to
ba6791d
Compare
# Conflicts: # Cargo.lock # prover/Cargo.lock # zkstack_cli/crates/zkstack/src/commands/chain/init/configs.rs
# Conflicts: # prover/crates/bin/circuit_prover/src/circuit_prover.rs # prover/crates/bin/circuit_prover/src/lib.rs # prover/crates/bin/circuit_prover/src/witness_vector_generator.rs # zkstack_cli/crates/zkstack/completion/zkstack.fish # zkstack_cli/crates/zkstack/completion/zkstack.sh
# Conflicts: # core/lib/l1_contract_interface/src/i_executor/methods/prove_batches.rs # core/node/eth_watch/src/client.rs # core/node/eth_watch/src/tests.rs # prover/Cargo.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Enables support of FFLONK compression
--flonk=true
flag to run compressor in FFLONK mode(or by runningzkstack prover run --component compressor --mode=fflonk
), default mode is still PLONKL1BatchProofForL1::Fflonk
orL1BatchProofForL1::Plonk
containing the proof insidecompression_mode
environment variable - FFLONK compressor can be run in 5 modes - 5th one is the most effective, so default value is 5.TODO:
Changes:
Why ❔
Checklist
zk fmt
andzk lint
.